[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30979 [Core Tor/Tor]: pre-push hook runs practracker unconditionally
#30979: pre-push hook runs practracker unconditionally
-----------------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status: reopened
Priority: Medium | Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: git-scripts asn-merge | Actual Points: 0
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
-----------------------------------+------------------------------------
Changes (by teor):
* status: closed => reopened
* resolution: fixed =>
Comment:
This ticket does not fix this issue:
* the pre-commit hook still calls practracker unconditionally
* the pre-push hook should never have added a duplicate call to
practracker in #30051, because it already calls the pre-commit hook, which
calls practracker
I'll create another PR that fixes these bugs.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30979#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs