[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30935 [Core Tor/Tor]: Move variable definition code out of confparse.c, and refactor

#30935: Move variable definition code out of confparse.c, and refactor
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  0.5
Parent ID:  #29211        |         Points:  1
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I think the flags need a redesign, so they are orthogonal, at least at the
 lowest level. And then the higher levels should use combinations of those
 flags. At the very least, there needs to be an overview comment describing
 how the flags interact at each level of abstraction, and between levels.

 In particular, it's weird having obsolete / no dump / invisible options,
 and then flags that do similar things a higher level of abstraction.
 See my review comment on the PR for details.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30935#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs