[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2189 [Tor Client]: Control Protocol Spec Error, Grammars Use Outdated Production ServiceID

#2189: Control Protocol Spec Error, Grammars Use Outdated Production ServiceID
---------------------------------+------------------------------------------
 Reporter:  Poet                 |        Type:  defect    
   Status:  needs_review         |    Priority:  minor     
Milestone:  Tor: 0.2.2.x-final   |   Component:  Tor Client
  Version:  Tor: 0.2.2.17-alpha  |    Keywords:            
   Parent:                       |  
---------------------------------+------------------------------------------

Comment(by nickm):

 Comments:
   * It's not correct to say "Before 0.1.2.2-alpha each line is...";
 instead you probably mean "In versions before 0.2.2.1-alpha, if
 VERBOSE_NAMES is not enabled, each line is..."  In other words, make it
 clear that you are describing not only versions before 0.1.2.2-alpha, but
 also versoins between 0.1.2.2-alpha and 0.2.2.1-alpha when VERBOSE_NAMES
 is not set.

 Otherwise, it looks fine to me.  One thing, though:  Your branch is
 against master.  Did we want this to go into 0.2.2?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2189#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs