Re: [tor-bugs] #2190 [Tor Client]: Possible reentrant calls to libevent from libevent logging callback

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#2190: Possible reentrant calls to libevent from libevent logging callback
------------------------+---------------------------------------------------
 Reporter:  nickm       |       Owner:  rransom           
     Type:  defect      |      Status:  needs_review      
 Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by rransom):

 boboper points out that the following statement in `logv` is not safe:
 {{{
   if (smartlist_len(pending_cb_messages))
     flush_pending_log_callbacks();
 }}}

 If two `LD_NOCB` messages were logged in a row, `logv` would call
 `flush_pending_log_callbacks` while handling a `LD_NOCB` message.

 Fixed in
 [http://repo.or.cz/w/tor/rransom.git/commitdiff/4a9d60734ce47cb3b5cb254e522116cd26b4823f
 4a9d60734ce47cb3b5cb254e522116cd26b4823f].  See
 [http://repo.or.cz/w/tor/rransom.git/shortlog/refs/heads/bug2190_the_hard_way
 bug2190_the_hard_way] ( !ssh://mob@xxxxxxxxxx/srv/git/tor/rransom.git
 bug2190_the_hard_way ).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2190#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs