Re: [tor-bugs] #1692 [Tor Relay]: No Events for SETCONF

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1692: No Events for SETCONF
-------------------------+--------------------------------------------------
 Reporter:  atagar       |       Owner:  atagar          
     Type:  enhancement  |      Status:  assigned        
 Priority:  minor        |   Milestone:  Tor: unspecified
Component:  Tor Relay    |     Version:                  
 Keywords:               |      Parent:                  
-------------------------+--------------------------------------------------
Changes (by atagar):

  * owner:  => atagar
  * status:  new => assigned


Comment:

 This looks like it'll be pretty simple tweak in set_options [1]. It's the
 common handler for the success case of both SETCONF and RELOAD/SIGHUP:

 SETCONF:
 1. handle_control_setconf(conn, cmd_data_len, args) ->
 2. control_setconf_helper(conn, len, body, 0) ->
 3. options_trial_assign(lines, use_defaults, clear_first, &errstring) ->
 4. set_options(trial_options, msg) ->

 SIGHUP:
 1. control_signal_act(sig) ->
 2. signal_callback(0,0,(void*)(uintptr_t)SIGHUP) ->
 3. do_hup() ->
 4. options_init_from_torrc(0, NULL) ->
 5. options_init_from_string(cf, command, command_arg, &errmsg) ->
 6. set_options(newoptions, msg)

 I'll add a proposed change either after work or tomorrow morning. Cheers!
 -Damian

 [1] https://gitweb.torproject.org/tor.git/blob/HEAD:/src/or/config.c#l645

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1692#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs