[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1666 [Tor Client]: SOCKS handling should accept (and ignore) password auth.



#1666: SOCKS handling should accept (and ignore) password auth.
-------------------------+--------------------------------------------------
 Reporter:  nickm        |       Owner:  mwenge            
     Type:  enhancement  |      Status:  needs_review      
 Priority:  normal       |   Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client   |     Version:                    
 Keywords:               |      Parent:                    
-------------------------+--------------------------------------------------

Comment(by nickm):

 Looks good to me.  There are a couple of whitespace things (like "}else")
 that we'll need to deal with, but otherwise I'm good to merge this after
 one last look.  I'm going to hold off till I'm back from vacation, though,
 since I won't be around to try to merge fixes if I'm wrong and this
 breaks.

 Also, instead of just draining the authentication info, we will eventually
 need to store it.  We might as well add that code while we're adding this
 patch, since it'll be fresh in our minds.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1666#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs