[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #933 [Tor Client]: MapAddress for domains?
#933: MapAddress for domains?
--------------------------+-------------------------------------------------
Reporter: Aleph0 | Owner: mwenge
Type: enhancement | Status: assigned
Priority: minor | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version: 0.2.0.33
Resolution: None | Keywords:
Parent: |
--------------------------+-------------------------------------------------
Comment(by mwenge):
Replying to [comment:8 nickm]:
> Almost there!
>
> The code to handle the * case of config_register_addressmaps seems to
allow too much: It skips over the * starting "*example.com", not just the
* starting "*.example.com".
Yes it does, fixed.
>
> I think that the current syntax is still too hard to read: Having
.mit.edu be distinct from mit.edu will IMO be too easy for people to screw
up. Can't we just have the * be mandatory, so that "a.b.c" stays the
same, but "." becomes "*" and ".example.com" becomes "*.example.com"?
OK - expressions with '.example.com' are now ignored.
>
> Now that we can have more than one rule apply to the same address, we
should be really explicit in the documentation about what we do when that
happens. I think the rule is, "If any rule applies, we apply whichever
rule was listed first, then check again and apply the one listed first,
and so on." Is that right? (Do we have a unit test for this case?)
Added a few notes to the man page and made the test for the recursion more
explicit.
>
> Minor style:
> * We initialize null pointers to NULL, not 0. (
addressmap_match_superdomains)
Fixed.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/933#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs