[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4655 [Tor Hidden Services]: Try clearing stream-isolation state on newly opened rendezvous circs

#4655: Try clearing stream-isolation state on newly opened rendezvous circs
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  defect               |         Status:  needs_review      
 Priority:  minor                |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by nickm):

 Looks okay to me.

 Should the "XXXX023 This is a pretty brute-force approach" comment die?

 And should the connection_ap_attach_pending() calls in
 circuit_try_attaching_streams() get a similar comment?

 (Also, because I know you sometimes share my penchant for pedantry, you
 might in the future consider that "return non-zero if X" is a less bullet-
 proof function specification than "return non-zero iff X".  But it's also
 okay to leave it as "if", and assume that everybody who cares will assume
 you meant "iff".)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4655#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs