[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4725 [Tor Bridge]: Managed proxies should not bind locally by default

#4725: Managed proxies should not bind locally by default
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by asn):

 Replying to [comment:2 nickm]:
 > That seems wrong to me.  We would want client proxies to listen on
 127.0.0.1, and server proxies to listen on INADDR_ANY, right?

 We don't set `TOR_PT_SERVER_BINDADDR` for client proxies, and they should,
 by default, listen on 127.0.0.1. We only set `TOR_PT_SERVER_BINDADDR` for
 server proxies [0].

 Please have a look at branch `bug4725_take2` where I use the INADDR_ANY
 definition, which I did not know of, instead of hardcoding "0.0.0.0".

 [0]:
 `set_managed_proxy_environment()`:
 {{{
   if (mp->is_server) {
     bindaddr = get_bindaddr_for_proxy(mp);
 ...
     tor_asprintf(tmp++, "TOR_PT_SERVER_BINDADDR=%s", bindaddr);
 ...
   }
 ...
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4725#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs