[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #4746 [Tor Relay]: Add a header to 'keys/dynamic_dh_params'.
#4746: Add a header to 'keys/dynamic_dh_params'.
-----------------------+----------------------------------------------------
Reporter: asn | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.3.x-final
Component: Tor Relay | Version:
Keywords: | Parent: #4548
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Comment(by asn):
Replying to [comment:2 nickm]:
> Hm. It's more usual to wrap this kind of thing in a PEM-style
----BEGIN/ -----END block. Also, we don't have any other "don't edit
this" disclaimer in the keys subdir of the data directory, so I don't know
that I need one here.
>
> Has this file actually confused anyone?
I think Roger Dingledine got confused by this file some days ago, and he
suggested adding a header. I think it doesn't hurt, and it might even help
people who are lost in their keys directory (I know I would appreciate the
header if I didn't know what the file was for.).
I don't have any preferences for the header string either. If we end up
keeping the header, please change the message to whatever you think is
better (or suggest something and I will change it).
Finally, notice that the branch will '''not''' replace the current
`keys/dynamic_dh_params`, with a `keys/dynamic_dh_params` with headers.
So, with this branch, relays who have already generated their dynamic DH
parameters, will not have headers in their files.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4746#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs