[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #4779 [Tor Relay]: AES broken since 0.2.3.9-alpha on CentOS 6
#4779: AES broken since 0.2.3.9-alpha on CentOS 6
-----------------------+----------------------------------------------------
Reporter: Pascal | Owner: nickm
Type: defect | Status: accepted
Priority: major | Milestone: Tor: 0.2.3.x-final
Component: Tor Relay | Version: Tor: 0.2.3.9-alpha
Keywords: aes | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Comment(by nickm):
Replying to [comment:18 rransom]:
> Replying to [comment:15 nickm]:
> > But before that, I could use some review on the test code, to make
sure that it actually uses the API correctly and tests what it is supposed
to test.
>
> Is `AES_ctr128_encrypt` documented anywhere?
The closest I can find is a comment on CRYPTO_ctr128_encrypt in
crypto/modes/ctr128.c . I think there was once a corresponding comment on
AES_ctr128_encrypt if you look at earlier OpenSSLs.
I note that my test code doesn't initialize ecount_buf, which is
technically not allowed, but makes no difference. (Tor does initialize
the equivalent buffer as it uses it.) Uploading a new version of the test
so that nobody can claim that this noncompliance matters.
Also, I am going to be in transit till Wednesday.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4779#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs