[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7598 [Tor]: STREAM event can have a zero port (was: Crash in StreamEvent handler)
#7598: STREAM event can have a zero port
----------------------+-----------------------------------------------------
Reporter: robinson | Owner: atagar
Type: defect | Status: new
Priority: normal | Milestone:
Component: Tor | Version:
Keywords: events | Parent: #7328
Points: | Actualpoints:
----------------------+-----------------------------------------------------
Changes (by atagar):
* component: Stem => Tor
Comment:
Hi robinson, thanks for the catch! Fixed and added a test for that
event...
https://gitweb.torproject.org/user/atagar/stem.git/commitdiff/61b74b1d924abb7be2cbc8e5a8ca7e95c379117e
Next assigning this to Nick to see if the spec can be improved. Questions
that I have are...
1. The STREAM event's Target and SOURCE_ADDR are both defined in the same
way...
{{{
Target = Address ":" Port
"SOURCE_ADDR=" Address ":" Port
}}}
Should the spec be specify that the SOURCE_ADDR's port can be zero? Can
the Target's port also be zero?
2. The 'Address' is defined as...
{{{
Address = ip4-address / ip6-address / hostname (XXXX Define these)
}}}
... but in this case the address is "(Tor_internal)". This is a special
value that comes from 'connection_edge.c'. We should probably document
what it means.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7598#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs