[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7328 [Stem]: Event Handling
#7328: Event Handling
-------------------------+--------------------------------------------------
Reporter: atagar | Owner: atagar
Type: enhancement | Status: assigned
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: controller | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Changes (by atagar):
* status: needs_revision => assigned
Comment:
Thanks, robinson, for the code review!
> Is it possible that stem.StreamClosureReason values map to an interger
starting with 1...
Not unless we add a filler value at the start of the enum. I'd advise
against using stem.StreamClosureReason indices, and instead use a dict
that maps ints to stem.StreamClosureReason. The reason for this is less
the offset that you mentioned, and more because StreamClosureReason
includes 'END' and 'PRIVATE_ADDR'. Those are values allowed for in STREAM
events, but not part of RELAY_END.
> The commit titled "Revised behavior for document signature methods" is
not relevant to events. It's not a big deal, but to avoid side effects
merging this branch, maybe you could cherry-pick around it?
Good point. Cherry-picked fe16cce, pushed it to master, and rewrote my
events branch to exclude it.
I'm swapping this back to the assigned status since I'm less than half way
through the event types. I'll swap this back to 'needs review' when I'm
done, though more code reviews as I go along would be very welcome.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7328#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs