[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7674 [Stem]: add version requirements to Event classes

#7674: add version requirements to Event classes
-------------------------+--------------------------------------------------
 Reporter:  robinson     |          Owner:  atagar
     Type:  enhancement  |         Status:  new   
 Priority:  normal       |      Milestone:        
Component:  Stem         |        Version:        
 Keywords:  events       |         Parent:        
   Points:               |   Actualpoints:        
-------------------------+--------------------------------------------------

Comment(by atagar):

 Shame on me. I saw your first ticket, looked over your other branches, and
 loved exp-event-versions-v1 so I pushed. I should have read the other
 tickets first...

 > Is this something we should add to Stem? Is this the format to use? I'd
 appreciate any feedback.

 Yup, it looks like a great addition. I squashed the commits a bit and made
 a minor tweak so add_event_listener() would be all-or-nothing...

 https://gitweb.torproject.org/stem.git/commitdiff/40827b365e3a5f3dac6d1f8e8ffddd589be6cd70

 But otherwise I can't think of any suggestions. Leaving this open since
 indeed a test or two would be good to have.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7674#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs