Re: [tor-bugs] #7676 [Ooni]: resume support

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#7676: resume support
-------------------------+--------------------------------------------------
 Reporter:  ioerror      |          Owner:  hellais
     Type:  enhancement  |         Status:  new    
 Priority:  normal       |      Milestone:         
Component:  Ooni         |        Version:         
 Keywords:               |         Parent:         
   Points:               |   Actualpoints:         
-------------------------+--------------------------------------------------
Changes (by hellais):

  * priority:  major => normal
  * type:  defect => enhancement


Comment:

 Yes, this is a limitation of the current resume support functionality,
 though it has nothing to do with thread safety.

 Thread safety has to do with the manipulation of in memory data structures
 from multiple threads at the same time. Most tests (the only exceptions
 are captive portal and netalyzr) do not even run in separate threads.

 Ideally though you should not have multiple instances of the same test be
 running at the same time. There should only be one instance of every test
 at any given time.

 It should be possible to extend the test inputs to support your need for
 having multiple inputs without requiring to have more than one test at the
 same time.

 For example in here:
 https://trac.torproject.org/projects/tor/ticket/7664#comment:2

 you should not have various different lists of DNS hostnames to lookup.
 Instead the list you give as input should be prioritized in the order in
 which you want the scan to occur.

 Also the resume support is *very* hackish and was just a quick way of
 getting it done. What we should have in the future (when we have the
 ooniprobe API) is the ability to keep track of state in memory and save it
 to database when the reactor is about to get killed by serializing the in-
 memory data structure that stores it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7676#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs