[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7666 [Stem]: Support TAKEOWNERSHIP command
#7666: Support TAKEOWNERSHIP command
-------------------------+--------------------------------------------------
Reporter: lunar | Owner: atagar
Type: enhancement | Status: needs_review
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by rransom):
Replying to [comment:3 atagar]:
> Hi lunar, thanks for the patch! I like Robert's suggestion about
asserting ownership when spawning the tor process - how does this look to
you both?
>
>
https://gitweb.torproject.org/stem.git/commitdiff/7fba50ff561578f746ceb3383b1bb16d709a14e3
In stem/control.py, `s/thrugh/through/`.
Using `sleep 10` as your dummy process in `test_take_ownership_via_pid`
seems a bit risky -- if the computer has a busy or slow (or failing) disk,
Tor (or sleep) may take more than 10 seconds to start. Since you're going
to kill that process anyway, having it run for a longer time (perhaps five
minutes) shouldn't hurt anything.
Your `Controller` class's support for the `TAKEOWNERSHIP` command assumes
that Stem will always be run in the same process-ID namespace as any Tor
process that it is asked to connect to. That's even more risky. When I
opened #7667, I had assumed that Stem already provided a way to start a
Tor process and automatically open a control-port connection to it; in
that case, it would have been nearly trivial for Stem to pass the âowned
Tor instanceâ flag from the function that launches Tor to the code that
connects to its control port.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7666#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs