[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #7742 [Stem]: re-attach event listeners -- reloaded
#7742: re-attach event listeners -- reloaded
-------------------------+--------------------------------------------------
Reporter: robinson | Owner: atagar
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: events | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Damian,
I looked more closely at the various authentication paths after your
email[0]. And I concluded, I still don't like the hook in
BaseController.msg. 8-)
This patch set[1] is my second attempt to find an alternative approach.
Basically, call _post_authentication() at the end of each
connection.authentication* function. This covers 2 of the 3 use cases you
presented.
If someone goes to the trouble to hand-compose an AUTHENTICATE message
string to send through BC.msg, they should be sophisticated enough to re-
attach event listeners on their own. Someone reaching that deeply into
the abstraction layer can protect themselves.
This is my last, best argument for moving the hook. I respect your
decision either way.
[0]: https://lists.torproject.org/pipermail/tor-
dev/2012-December/004276.html
[1]: https://gitorious.org/stem-robinson/stem-robinson/commits/exp-
reattach-listeners-v2
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7742>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs