[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7693 [Stem]: add way to test with traffic through the tor server

#7693: add way to test with traffic through the tor server
-------------------------+--------------------------------------------------
 Reporter:  robinson     |          Owner:  robinson      
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Stem         |        Version:                
 Keywords:  testing      |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by atagar):

  * status:  needs_review => needs_revision


Comment:

 Hi Sean. Looks good, I pushed some changes to the 'exp-socks5' branch of
 my personal repo - thoughts?

 https://gitweb.torproject.org/user/atagar/stem.git/commitdiff/c5c886bfa9229d153f0c05327a1b1ef732b276fa

 I also had a few questions while reviewing this...

 * Would something like this be useful for stem users for scripting against
 tor (ie, should we have something like this in stem/socket.py instead)? If
 so then is there something that we can do about the DNS leakage that you
 mentioned? I'm thinking that this might be useful for #7505.

 * Can we merge in any remaining useful bits from 'test/util.py', or shall
 we drop external_ip()? It looks to be unused.

 * Speaking of util.py, the test that used it should probably be fixed
 (integ tests will now break if you give it the ONLINE target)...

 {{{
 atagar@morrigan:~/Desktop/stem$ grep -R "test.util" ./* | grep -v '.pyc'
 ./test/integ/control/controller.py:import test.util
 ./test/integ/control/controller.py:      test.util.negotiate_socks(s,
 '1.2.1.2', 80)
 ./test/integ/control/controller.py:      s.sendall(test.util.ip_request) #
 make the http request for the ip address
 }}}

 * What does the trailing underscore in "type_" indicate and why is there
 an unused "_sock" argument? Do these come from the socket.socket's
 constructor definition?

 Cheers! -Damian

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7693#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs