[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7157 [Tor]: "Low circuit success rate %u/%u for guard %s=%s."
#7157: "Low circuit success rate %u/%u for guard %s=%s."
-----------------------------------------+----------------------------------
Reporter: arma | Owner:
Type: enhancement | Status: needs_revision
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version:
Keywords: tor-client, MikePerry201212 | Parent: #5456
Points: | Actualpoints: 19
-----------------------------------------+----------------------------------
Comment(by mikeperry):
Replying to [comment:20 nickm]:
> Replying to [comment:19 mikeperry]:
> > > Do we verify that scale_factor strictly less than mult_factor? It
looks like
> > > in ef1b830ef8d751172ebe5 we removed the requirement, making it so
> > > scale_factor == mult_factor is allowed.
> >
> > I think this is fine. It doesn't cause damage if this happens, it
merely allows us to disable scaling entirely if we want, right?
>
> I think that's okay so long as we definitely prevent scale_factor >
mult_factor.
We do when the value comes from the consensus through the bounds on
networkstatus_get_param(). We currently let the user set whatever insane
values they like for all of these parameters, though...
The part 1 commit is now pushed, btw.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7157#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs