[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6124 [Flashproxy]: Flash proxy facilitator should not give IPv6 addresses to IPv4 proxies

#6124: Flash proxy facilitator should not give IPv6 addresses to IPv4 proxies
------------------------+---------------------------------------------------
 Reporter:  dcf         |          Owner:  jct           
     Type:  defect      |         Status:  needs_revision
 Priority:  normal      |      Milestone:                
Component:  Flashproxy  |        Version:                
 Keywords:              |         Parent:                
   Points:              |   Actualpoints:                
------------------------+---------------------------------------------------
Changes (by dcf):

  * status:  assigned => needs_revision


Comment:

 Replying to [comment:6 jct]:
 > The new attached patch is doing the suggested previously.
 >
 > The included suite test ('''ticket-6124-test.py''') is testing the new
 function '''ip_ver''', the modified '''parse_addr_spec''' and the
 Facilitator behaviour with IPv4/IPv6 proxies and clients.

 I am not quite happy with this patch. It rewrites `parse_addr_spec` in a
 less straightforward way, and changes its behavior in ways that are not
 obvious.

 I added some of the test cases to master; these are the only new tests I
 want. I don't want an `ip_ver` that is complicated enough to need lots of
 tests.

 I'll attach a patch that is more in line with how I want this to be
 implemented. Please base the remaining work off of it. (Apply it with `git
 am`.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6124#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs