[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7693 [Stem]: add way to test with traffic through the tor server

#7693: add way to test with traffic through the tor server
----------------------------+-----------------------------------------------
    Reporter:  robinson     |       Owner:  robinson
        Type:  enhancement  |      Status:  closed  
    Priority:  normal       |   Milestone:          
   Component:  Stem         |     Version:          
  Resolution:  implemented  |    Keywords:  testing 
      Parent:               |      Points:          
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by atagar):

  * status:  needs_review => closed
  * resolution:  => implemented


Comment:

 Looks good! Pushed your exp-socks5-v2 branch.

 > A) No, please resist feature creep. Stem is a Tor controller library,
 not a general network communications framework. For proxy use in Python, I
 recommend neehi[1].

 Agreed. Must... resist...

 My thinking on this was just that client usage is going to be a common set
 of use cases for stem. We need to have tutorials for how to safely do it.
 If we can do it without additional dependencies then great, if not then
 that's fine too - I'm fine with suggesting something like your neehi
 library to our client users if you think that is the best option.

 That said, shouldn't we use whatever we end up suggesting for own integ
 tests? I definitely like the idea of limiting stem's dependencies, but for
 integ testing using the library that we suggest might make sense.

 > I left test/util.py alone in the new patch set. We can look at clean-
 up/removal after test/betwork.py is in-use.

 Ok. Honestly I've also been itching a bit to remove or rename test/util.py
 since its been throwing off my tab completion for test/unit/*. :P

 Resolving. Feel free to reopen if there's something left to do on this
 ticket.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7693#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs