[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6612 [Compass]: sort according to table header in Compass
#6612: sort according to table header in Compass
-------------------------+--------------------------------------------------
Reporter: gsathya | Owner: gsathya
Type: enhancement | Status: needs_revision
Priority: normal | Milestone:
Component: Compass | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by cwacek):
Replying to [comment:11 cwacek]:
> Replying to [comment:9 gsathya]:
> > Thanks a lot for the changes! This is a pretty big merge which changes
a lot of things and I'm still only halfway through reviewing this. I
wanted to hold of commenting on this until I finished the review, but I'd
like to sort out a few things before we proceed.
> >
> > 1) The URL's no longer change (it's not bookmark-able -- you can't
share it). Is this ok? I distinctly remember arma wanting this in the
beginning.
>
> Ah, I was not there in the beginning so I didn't know this. However, I
think that this is a solvable problem (and this ties into your next
question), because I can make Angular make sure the urls are bookmarkable.
I'll take a look and see if this can be done.
>
> > 2) Why use angular.js if the sorting is going to be done by the
backend?
>
> Angular handles the AJAX callbacks very nicely in terms of updating the
data displayed. It also might make addressing your first point very easy.
>
> > 3) When grouping by country, the fingerprint column only says "(XXX
rel)" (should be "XXX relays") and remains a hyperlink.
>
> Ack I'll fix that.
>
>
>
I've pushed a couple changes that address the points you've raised
gsathya. URLs now map to the queries that are made, allowing one to 'save'
or bookmark searches. I also fixed the handling of the FP field when
grouping by country.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6612#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs