[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10066 [EFF-HTTPS Everywhere]: Incorrect git hash used by makexpi.sh and merge-rulesets.py

#10066: Incorrect git hash used by makexpi.sh and merge-rulesets.py
--------------------------------------+--------------------
     Reporter:  mikeperry             |      Owner:  zyan
         Type:  defect                |     Status:  closed
     Priority:  major                 |  Milestone:
    Component:  EFF-HTTPS Everywhere  |    Version:
   Resolution:  wontfix               |   Keywords:
Actual Points:                        |  Parent ID:
       Points:                        |
--------------------------------------+--------------------
Changes (by jsha):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 I think this is working as intended. If you want to build a given tag,
 e.g. 4.0.2, you run:

 ./makexpi.sh 4.0.2

 The script creates a temporary checkout directory, cds into it, checks out
 the tag, and re-runs makexpi. In that context the master commit id is
 correct. I tried running ./makexpi.sh 4.0.2 starting from two different
 head commit ids, and got identical output.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10066#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs