[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17696 [metrics-lib]: patch for missing torperf annotaion
#17696: patch for missing torperf annotaion
-------------------------+------------------------------
Reporter: iwakeh | Owner: karsten
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Sponsor: |
-------------------------+------------------------------
Changes (by karsten):
* status: needs_information => needs_review
Comment:
The patches look good, though I'd want to implement the fix slightly
different. I just pushed [https://gitweb.torproject.org/user/karsten
/metrics-lib.git/log/?h=task-17696 branch task-17696 to my public
repository] which contains iwakeh's patches, some cleanups, and a slightly
different implementation that produces the same result. If you like it,
I'll squash and merge that. If not, please provide a patch based on my
branch or tell me which of my subsequent commits you dislike.
Regarding the question above whether there should be an annotation for
each line containing measurements, I think I agree with iwakeh. metrics-
lib does the right thing here, with this patch. It's CollecTor that is
broken which should put in a @type annotation for each measurement line.
But I'll consult atagar who typically helps with discussions about @type
annotations and Rob Jansen who works on a successor of Torperf and who
just recently started producing @type torperf 1.0 files. This should
become a new ticket then, either for metrics-lib if I'm wrong here, or for
CollecTor if I'm right.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17696#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs