[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17608 [Tor]: Refactor accept/reject * redundancy checks out of policies_parse_exit_policy_internal

#17608: Refactor accept/reject * redundancy checks out of
policies_parse_exit_policy_internal
---------------------------+------------------------------------
 Reporter:  teor           |          Owner:
     Type:  enhancement    |         Status:  needs_review
 Priority:  Very Low       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor            |        Version:  Tor: 0.2.7.3-rc
 Severity:  Minor          |     Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID:                 |         Points:
  Sponsor:                 |
---------------------------+------------------------------------
Changes (by teor):

 * milestone:   => Tor: 0.2.8.x-final


Comment:

 Thanks for this patch, looks great. I'm sorry I didn't get to this sooner,
 it's been a rather hectic 2 weeks.

 I'd encourage you to submit more patches like this. I'll try hard to get
 to it within a week. If I miss it, you can get my attention on IRC or on
 the ticket.

 Code review:

 This is a code movement patch.
 It refactors code for readability, it doesn't modify the behaviour of Tor
 at all.

 I added a changes file. (Every change gets a changes file. They're
 combined into the ChangeLog with each release.)

 I added a commit that modifies the patch slightly:
 * Make policies_log_first_redundant_entry take a `const smartlist_t *`, as
 it doesn't need to modify the smartlist, or the smartlist pointer. (Also
 assert that the list is not NULL.)
 * Make the patch conform to tor's code style. Code style can be checked
 using `make check-spaces`.
 * Keep DEFAULT_EXIT_POLICY just before the function it's used in.

 Both commits are in the branch `refactor-effective-entry` on
 https://github.com/teor2345/tor.git

 You can see what's in the branch (compared to master) at
 https://github.com/teor2345/tor/compare/refactor-effective-entry

 Let's get this merged to master!
 (There's no need to backport refactoring to 0.2.7.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17608#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs