Re: [tor-bugs] #17753 [Tor]: Use internal reputation variables to verify memory allocation

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17753: Use internal reputation variables to verify memory allocation
-------------------------+------------------------------------
 Reporter:  cypherpunks  |          Owner:
     Type:  defect       |         Status:  needs_revision
 Priority:  Low          |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:  Tor: unspecified
 Severity:  Minor        |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [comment:2 teor]:
 > Can you explain the removal of the cast from the line:
 > `lhist = (link_history_t*) digestmap_get(orhist->link_history_map,
 to_id); `
 As explained in the commit message, i found this unnecessary cast while
 working on the code. The digestmap returns a pointer to void so it
 automatically converts to whatever pointer type you assign it to already,
 no cast necessary.
 > Did you mean to include it in the patch?
 I did mean to include it in the patch because it was such a small change,
 but i agree that is it a bit unrelated. Should i split the commit in two?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17753#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs