[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17770 [Tor Browser]: Buttons on donation banner on about:tor are misaligned sometimes

#17770: Buttons on donation banner on about:tor are misaligned sometimes
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  High                                 |         Status:  new
Component:  Tor Browser                          |      Milestone:
 Severity:  Major                                |        Version:
 Keywords:  funding, crowdfunding, donations,    |     Resolution:
  TorBrowserTeam201512                           |  Actual Points:
Parent ID:  #17534                               |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Here's a patch that I think fixes these issues. I was debating whether to
 only activate the buttons, or allow clicking anywhere on the banner lead
 to the donation page. I'm leaning toward leaving the whole banner link
 active, because I think some users may click on the banner and not
 understand why nothing is happening. But I am not 100% sure this is the
 right answer.

 https://github.com/arthuredelstein/torbutton/commit/17770

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17770#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs