[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15564 [Tor Browser]: Isolate SharedWorker by first party domain



#15564: Isolate SharedWorker by first party domain
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_revision
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-linkability, tbb-usability-      |        Version:
  website, TorBrowserTeam201512R                 |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  needs_review => needs_revision
 * severity:   => Normal


Comment:

 Kathy and I reviewed this and the code looks correct. Nice work! Of course
 we have a few comments:

 - Since the dom.workers.sharedWorkers.enabled pref is true by default, we
 probably should just remove it from 000-tor-browser.js.
 - Inside dom/base/test/test_tor_bug15564.html near setPref there is a typo
 in a comment: "prmoise" should be "promise".
 - Is it customary to close tabs in test code or not? Kathy and I did so in
 docshell/test/test_tor_bug16620.html but you did not here. I can see that
 leaving them open would be helpful for debugging individual test cases but
 I do not know what the norm is for Mozilla test code.
 - It took us a little while to understand the flow of messages in the test
 code. Maybe add a few comments to help new readers.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15564#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs