Re: [tor-bugs] #17739 [Tor]: Refactor clock skew warning code to avoid duplication

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17739: Refactor clock skew warning code to avoid duplication
---------------------------------------------+-----------------------------
 Reporter:  teor                             |          Owner:
     Type:  enhancement                      |         Status:
 Priority:  Medium                           |  needs_review
Component:  Tor                              |      Milestone:  Tor:
 Severity:  Normal                           |  0.2.8.x-final
 Keywords:  easy refactor TorCoreTeam201512  |        Version:  Tor:
Parent ID:  #9675                            |  unspecified
  Sponsor:                                   |     Resolution:
                                             |  Actual Points:
                                             |         Points:
---------------------------------------------+-----------------------------
Changes (by arlolra):

 * status:  needs_revision => needs_review


Comment:

 > let's describe the parameters in a comment (other functions do this),
 and make the pointers const.

 Done

 > Can you update the patch so it calls clock_skew_warning from
 or_state_load?

 The only shared part is the string, `"Tor requires an accurate clock to
 work: please check your time, timezone, and date settings."` If you want,
 we can put somewhere and interpolate it in both places. Otherwise, how
 would you suggest I update the patch?

 > Note that servers could be wrong or lying about the time

 Done

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17739#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs