Re: [tor-bugs] #17617 [metrics-lib]: Parse flag thresholds and provide them as double values in BridgeNetworkStatus and RelayNetworkStatusVote

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17617: Parse flag thresholds and provide them as double values in
BridgeNetworkStatus and RelayNetworkStatusVote
-------------------------+-----------------------------
 Reporter:  karsten      |          Owner:  karsten
     Type:  enhancement  |         Status:  closed
 Priority:  Medium       |      Milestone:
Component:  metrics-lib  |        Version:
 Severity:  Normal       |     Resolution:  implemented
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+-----------------------------
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Replying to [comment:3 iwakeh]:
 > Why not make the newly added method comments javadoc?
 > And, maybe verify the other comments in the same interface and make them
 javacoc, too?
 > Would be a start for the javadoc issue.

 I'd rather want to have a discussion about what exactly to include in
 JavaDoc comments first, because it's just too easy to make them very
 verbose and very useless.  Once we agree on something, it's probably
 easier if I sit down for a few hours and edit all comments to turn them
 into JavaDoc comments.  Let's discuss this on #16873.  This shouldn't stop
 us from merging this patch.

 > In addition, metrics-lib should actually upgrade to java 7.
 >
 > [https://www.oracle.com/technetwork/java/javase/downloads/java-archive-
 downloads-javase6-419409.html Oracle.com]
 > {{{
 > WARNING: These older versions of the JRE and JDK are provided to help
 developers debug issues in
 > older systems. They are not updated with the latest security patches and
 are not recommended for use
 > in production.
 > ...
 > }}}
 > It's really outdated by now (onionoo also uses 7) and the timing with
 the first release would be right.
 > It could also avoid the endless if-else-if statements using string
 switches.

 Yep, we already switched to Java 7 just in time for the 1.0.0 release.

 If you have suggestions for making the code cleaner now that we're using
 Java 7, please create another ticket.  Happy to make the code cleaner if
 we can!

 There, I just merged this patch into master, with the only change being an
 entry in the change log.  Resolving.  Please re-open if I missed
 something.  Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17617#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs