[tor-bugs] #17818 [Tor]: weird "export"s in Makefile break old BSD make

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17818: weird "export"s in Makefile break old BSD make
------------------------+--------------------------
     Reporter:  wiz     |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:
    Component:  Tor     |    Version:  Tor: 0.2.7.5
     Severity:  Normal  |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+--------------------------
 With the 0.2.7.5 (compared to 0.2.6.*) there's a new build problem with
 older BSD makes.
 There is a bug report against pkgsrc in http://gnats.netbsd.org/50521

 The problem are weird targets that have:

 foo:
 export BAR=baz

 where the export is not indented with a tab

 I'm not sure what's intended here.
 They look like empty targets, but then what should the exports do?

 In particular:

 micro-revision.i
 #export TESTING_TOR_BINARY=$(top_builddir)/src/or/tor-cov
 export TESTING_TOR_BINARY=$(top_builddir)/src/or/tor

 and another few export lines following "FORCE:" about 10 lines below that.

 Using newer BSD makes or GNU make is a workaround, but it's not clear
 to me what is even the intention here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17818>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs