[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17821 [metrics-lib]: adapt metrics-lib to actual tordnsel format
#17821: adapt metrics-lib to actual tordnsel format
-------------------------+-----------------------------------
Reporter: iwakeh | Owner: karsten
Type: defect | Status: needs_information
Priority: Medium | Milestone:
Component: metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Sponsor: |
-------------------------+-----------------------------------
Comment (by karsten):
Thanks for picking this up!
I think this is a fine approach, including making the current
`getExitAddress()` method return the first entry and at the same time
deprecating it.
One thing though: if we use a `List<String>` as return type for the new
`getExitAddresses()` method, we'd lose the second scan time. How about a
`Map<String, Long>` with address as key and scan time in milliseconds as
value? We'd also have to deprecate `getScanMillis()` in that case, which
would be okay.
Here's a slightly unrelated idea I had yesterday: how about we avoid
having `ExitListEntry` be its own type in parallel to `ExitList` and
rather turn it into `ExitList.Entry`? It's only used when processing exit
lists anyway, and it would help clean up the API a tiny bit. If we're
changing the API there now, why not change this, too. But, just a
thought, this can easily be done in a separate commit after yours is in.
Though ideally, if we agree it's a good idea, it should get into the same
release.
Thanks again!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17821#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs