Re: [tor-bugs] #17821 [metrics-lib]: adapt metrics-lib to actual tordnsel format

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17821: adapt metrics-lib to actual tordnsel format
-------------------------+-----------------------------------
 Reporter:  iwakeh       |          Owner:  karsten
     Type:  defect       |         Status:  needs_information
 Priority:  Medium       |      Milestone:
Component:  metrics-lib  |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+-----------------------------------

Comment (by iwakeh):

 Yes, I can add this change to the patch.
 Only one naming issue: I'd prefer to name {{{public Set<ExitList.Entry>
 entrySet()}}} something like
 {{{public Set<ExitList.Entry> getEntries()}}}.
 The name 'entrySet' makes me think of java's 'Map.Entry',which would be
 misleading.

 I didn't notice {{{getScanMillis()}}}. It would then have to return the
 time for the ExitAddress
 returned in {{{getExitAddress()}}}.
 And, of course, getExitAddresses should return a Map<String, Long>. I
 suppose there won't be any ExitAddress lines with the same ip address and
 different scan time.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17821#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs