[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17823 [metrics-lib]: use diamond operator
#17823: use diamond operator
-------------------------+--------------------------
Reporter: iwakeh | Owner: karsten
Type: enhancement | Status: accepted
Priority: Low | Milestone:
Component: metrics-lib | Version:
Severity: Minor | Resolution:
Keywords: | Actual Points:
Parent ID: #17822 | Points:
Sponsor: |
-------------------------+--------------------------
Comment (by karsten):
I like the idea of trying this out in code that we're changing anyway.
But I think we'll have to make the remaining changes in bulk at some
point, and I suggest doing that prior to the next release. Otherwise, we
might not make these changes in code that we're not touching for months or
even years, and until we do, we'll have a ticket open that is not
actionable.
Of course, the alternative would be that we agree this is a good change
(which we do!), write down in CONTRIB.md that we want to do this for new
code, and then close this ticket. I'm okay with this, too, though I think
it's not that much work to just make these changes in bulk:
{{{
~/src/metrics-lib$ git grep "new.*<" | wc -l
176
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17823#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs