[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17826 [Tor]: tor not make-jobs safe

#17826: tor not make-jobs safe
--------------------+------------------------------------
 Reporter:  wiz     |          Owner:
     Type:  defect  |         Status:  needs_review
 Priority:  Medium  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor     |        Version:  Tor: 0.2.4.2-alpha
 Severity:  Normal  |     Resolution:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
  Sponsor:          |
--------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [comment:4 nickm]:
 > Does this work with out-of-tree builds?
 It should work with out-of-tree builds because i only use those and it
 worked fine. Also `make distcheck` ran successfully.
 >It reverts a commit that says that it's necessary in order to fix out-of-
 tree builds.
 The changes file of the reverted commit mentions something about ''under
 some circumstances'' but all i could find was ticket:6778#comment:3 which
 is about src/or/tor_main.c itself and not micro-revision.i.

 > FWICT the problem here is really that there are other object files
 besides log.o.  Specifically, I believe that Makefile.in will now also
 potentially include:
 >   * src/common/log.obj
 >   * src/common/src_common_libor_testing_a-log.o
 >   * src/common/src_common_libor_testing_a-log.obj
 These targets (expect for src/common/log.obj which i can't find in
 Makefile.in or Makefile) all have src/common/log.c as their prerequisite.
 With the patches this will make `make` search for rules with
 src/common/log.c as its target, find it, look at its prerequisite (which
 is `micro-revision.i`) and rebuild it.

 BTW, the problem is reproducible by trying to `make src/or/src_or_tor_cov-
 tor_main.o` or `make src/common/src_common_libor_testing_a-log.o` on a
 fresh build (clean directory with only ./configure called). It won't build
 micro-revision.i. These patches fix the problem.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17826#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs