[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7144 [Tor]: Implement Bridge Guards and other anti-enumeration defenses
#7144: Implement Bridge Guards and other anti-enumeration defenses
-------------------------------------------------+-------------------------
Reporter: karsten | Owner:
Type: project | Status:
Priority: High | needs_review
Component: Tor | Milestone: Tor:
Severity: Normal | 0.2.8.x-final
Keywords: SponsorZ, tor-bridge, | Version:
027-triaged-1-out, TorCoreTeam201509, | Resolution:
028-triage, 028-triaged | Actual Points:
Parent ID: | Points: medium
Sponsor: |
-------------------------------------------------+-------------------------
Comment (by nickm):
Now to review the command.c changes and loose.c in
e81acaf5f33e7c6de4205dfdc8d797c3bd9dbd80.
command.c:
* command_answer_create_cell has no documentation.
loose.c:
* I recommend that after we merge we rename this to loosecirc.c or
something.
* Arg. Unless I miss my guess, there is waaay to much copied code from
origin_circuit_t here. Cut-and-paste programming is a sad thing. I can't
tell what's new and what isn't, what's different and what isn't. I
wonder, can we extract the common fields from origin_circuit_t and
loose_circuit_t into a new type, refactor the origin_circuit_t functions
to work on that, and then redefine many/most of these functions in terms
of the refactored origin_circuit_t stuff?
* If the above change were done, this would be much easier to review,
since I wouldn't have to hand-compare it to the origin_circuit_t code.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7144#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs