[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17783 [Tor]: Pull in a SHA-3 implementation.

#17783: Pull in a SHA-3 implementation.
-----------------------------+------------------------------------
 Reporter:  yawning          |          Owner:  yawning
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor              |        Version:  Tor: unspecified
 Severity:  Normal           |     Resolution:
 Keywords:  tor-core crypto  |  Actual Points:
Parent ID:                   |         Points:
  Sponsor:                   |
-----------------------------+------------------------------------

Comment (by yawning):

 Checkpointing: https://github.com/Yawning/tor/compare/feature17783_take2
 (nb: This may get rebased/tramped on/etc, probably not).

 The incremental API is cleaner (IMO), and is self-contained without tor-
 isms in 1 commit so should be easy to upstream if so desired.  There
 aren't huge changes to how it's used, though there's separate init calls
 (that take bits instead of target, yay) for use as a digest or XOF.

 TODO:
  * more test vectors, including the empty vector, vectors exactly equal to
 one/two input block size, vectors equal to one/two input block sizes plus
 or minus one, a single-character input, and something with a NUL in the
 middle.
  * Although we don't do this with the other incremental digests, I'd like
 to see is do a pretty rigorous test on the incremental update function --
 possibly randomized tests where we generate a big random buffer and add it
 incrementally in random-sized chunks and make sure we get the same output
 each time. (I think this is a good idea because in this case the
 incremental update code is our own.)

 I even tested building it with clang in addition to GCC this time.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17783#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs