[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20716 [Core Tor/Tor]: memory leak in connection_handle_listener_read()

#20716: memory leak in connection_handle_listener_read()
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.6.3-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  028-backport 027-backport            |  Actual Points:
  026-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by icanhasaccount):

 Hi Nick

 Ugh, I think I need to read through K+R again before I send any more
 patches ><

 Your patch reads fine to me FWIW.

 The other thing I'd considered was splitting up the (conn->socket_family
 == AF_UNIX && new_type == CONN_TYPE_AP) case into a separate conditional
 (this happens for (conn->socket_family == AF_UNIX && conn->type !=
 CONN_TYPE_AP) below but I can always send in a patch for that later if its
 worth it.

 Thanks again and for the feedback

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20716#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs