[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18757 [Core Tor/Tor]: Memunit config defaults say "KB" rather than "KBytes"
#18757: Memunit config defaults say "KB" rather than "KBytes"
--------------------------+------------------------------------
Reporter: arma | Owner:
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: easy | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Changes (by teor):
* status: needs_review => needs_revision
Comment:
Thanks for the patch!
I'm not sure if we should change the ChangeLog (arma and nickm might have
an opinion about this).
I think the manual changes are fine.
The changes to the updateFallbackDirs.py should be ok, but they need to be
put into a separate patch, so they can be included when the script is run
over the next few days. This will make the change to fallback_dirs.inc
unnecessary - we're going to replace it very soon.
I think we have a special process for staging changes to the torrc files.
nickm knows more about this than I do.
Please don't delete the final empty line from src/config/torrc.sample.in
"(byte, KBytes, M, etc)" should be "(byte, KBytes, MBytes, etc)"
Would you mind changing "We just generated an extra-info descriptors that"
to "We just generated an extra-info descriptor that" while you're there?
You might want to run `make check-spaces` to ensure that the line lengths
are still ok.
Since you have changed log messages, please run `make check` to ensure all
the unit tests still pass.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18757#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs