[tor-bugs] #21037 [Core Tor/Tor]: Scary log message "AAAA...AAA" in connection_or_set_identity_digest()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21037: Scary log message "AAAA...AAA" in connection_or_set_identity_digest()
------------------------------+--------------------------------
     Reporter:  arma          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.0.1-alpha
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 On moria1 running today's 0.3.0.1-alpha-dev, I see these info-level logs:
 {{{
 Dec 19 20:42:39.727 [info] connection_or_set_identity_digest(): Set
 identity digest for 0x1369a250 ((null)):
 FFD94A523D3A66323E3E4F7707AFCBD44A8D38C4 <null>.
 Dec 19 20:42:39.727 [info] connection_or_set_identity_digest():
 (Previously: 0000000000000000000000000000000000000000
 AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA)
 }}}

 That last part reminds me of elsewhere in our code where we do
 {{{
     memwipe(mem, 0xAA, memlen); /* poison memory */
 }}}

 Coincidence? I think it is, because I bet AAA..AAA is the base64 of
 000..000, since I see ed25519_fmt() returns a base64 thing.

 Still, I wonder if we might do a smarter log message for the case where
 the key used to be unset, since I'm not the only person who is going to
 see this line and be concerned.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21037>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs