[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20919 [Core Tor/Tor]: Extract prop271 state-parsing code into a generic thing

#20919: Extract prop271 state-parsing code into a generic thing
-----------------------------------+------------------------------------
 Reporter:  nickm                  |          Owner:
     Type:  defect                 |         Status:  new
 Priority:  Medium                 |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor           |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  triage-out-030-201612  |  Actual Points:
Parent ID:  #20822                 |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------------

Comment (by nickm):

 >  Is it more elegant?

 IMO it isn't.  It requires separate config_lines for anything, requires a
 loop over all the lines, and is harder to read as a function.

 We have lots of places throughout our code that use a space-separated K=V
 metaformat, like FooPort lines and so on.  It could be cool to refactor
 all of those, and this, to use a common parser.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20919#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs