[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20168 [Core Tor/Tor]: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif

#20168: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  cjb
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very Low                             |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Trivial                              |     Resolution:
 Keywords:  easy, lorax, nickm-                  |  Actual Points:
  deferred-20161005                              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 I tried running this with:
 {{{
 for fn in src/common/*.[ch] src/or/*.[ch] src/test/*.[ch] src/tools/*.[ch]
 ; do
    vim -c ':SmartPreProcCommenter' -c ':wq' $fn;
 done
 }}}

 I'm getting some pretty weird results though -- for instance, in compat.c,
 it makes this:
 {{{
 #if !defined(_WIN32)
 /** Defined iff we need to add locks whena defining fake versions of
 reentrant
  * versions of time-related functions. */
 #define TIME_FNS_NEED_LOCKS
 #endif /* HAVE_GMTIME_R, defined(TIME_FNS_NEED_LOCKS),
 defined(TIME_FNS_NEED_LOCKS) */
 }}}

 That can't be right, can it?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20168#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs