[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #12514 [Applications/Tor Browser]: Tor Button does not work unless Navigation toolbar is enabled
#12514: Tor Button does not work unless Navigation toolbar is enabled
-------------------------------------------------+-------------------------
Reporter: pursuit81 | Owner: tbb-
| team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-usability, tbb-torbutton, tbb- | Actual Points:
easy |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by mcs):
Replying to [comment:10 aruna1234]:
> So, I'll have to change the <menupopup id="torbutton-context-menu"/> id
to the <menuPopupSet id="torbutton-context-menu"/> I believe?
I do not think this is correct. The root cause of this bug is that the
<menupopup> is a child of the nav-bar, which means it is not available if
the Navigation Toolbar is removed from the user interface. To fix this
issue, the <menupopup> needs to be a child of a different element, one
that is always present. In comment:7 I suggested making it a child of the
mainPopupSet element. You can find an example of similar code here:
https://dxr.mozilla.org/mozilla-esr52/source/browser/base/content/web-
panels.xul#50
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12514#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs