[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20699 [Core Tor/Tor]: prop224: Add control port events and commands
#20699: prop224: Add control port events and commands
-------------------------------------------------+-------------------------
Reporter: dgoulet | Owner: dgoulet
Type: enhancement | Status:
| needs_review
Priority: Very High | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, needs-proposal, | Actual Points:
prop224-extra, tor-control, prop284, review- |
group-26, review-group-27 |
Parent ID: | Points: 6
Reviewer: nickm | Sponsor:
| SponsorR-must
-------------------------------------------------+-------------------------
Changes (by dgoulet):
* status: needs_revision => needs_review
Comment:
Replying to [comment:22 nickm]:
> Nice! This looks pretty solid and straightforward. I've left some
comments on the oniongit ticket.
I've answered them all.
> Additionally:
>
> It needs a changes file.
It is commit `86c53d768b63acc30363b470029597a1f5ee6aed`.
>
> Do all the stem tests still pass?
They all do except `test_dump_config_argument` which seems to be not
related to this branch but rather some memleak that libasan picks up and
thus fails the test. Seems related to `SchedulerTypes_` list leaking...
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20699#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs