[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus
#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
-----------------------------------+------------------------------------
Reporter: teor | Owner: teor
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ipv6, review-group-27 | Actual Points: 1
Parent ID: #20916 | Points: 0.5
Reviewer: dgoulet | Sponsor:
-----------------------------------+------------------------------------
Changes (by dgoulet):
* status: needs_review => needs_revision
Comment:
* (Nitpick) For some more safety, I would `const` this variable:
{{{
networkstatus_t *cons = networkstatus_get_reasonably_live_consensus(
}}}
Apart from that lgtm;
Although a question, `node_awaiting_ipv6()` doesn't check for the
descriptor (`node->ri`) anymore and the only trace for a reason of this I
can find is in the commit message:
{{{
If node_is_a_configured_bridge(), stop waiting for its IPv6 address in
a microdescriptor. The previous check for ri was inaccurate.
}}}
So was it specifically done before because of bridges and turned out to be
inaccurate? Or because now `node_has_ipv6_addr()` before takes care of
looking at the descriptor if one?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23827#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs