[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24218 [Metrics/Statistics]: Implement new metrics-web module for IPv6 relay statistics

#24218: Implement new metrics-web module for IPv6 relay statistics
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  iwakeh              |        Sponsor:
--------------------------------+------------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 All good suggestions above! Please do another review of
 [https://gitweb.torproject.org/karsten/metrics-
 web.git/commit/?h=tasks-24218-23761&id=ba969fe47c2c40949f3c51b6f9e80c9a633a52cc
 squash commit ba969fe in my tasks-24218-23761 branch].

 Regarding the error with `ON CONFLICT`, can you check which PostgreSQL
 version you have? That's a relatively new feature that I think was added
 in 9.5, but I checked that Debian stretch has 9.6, so it ''should'' be
 available. (I tried only locally with the PostgreSQL I got from brew.) If
 it is ''not'' available, I'll have to rewrite things quite a bit.

 Regarding the module renaming, I'm fine with `ipv6servers`. How about I
 rename things after you're done with your review? Otherwise that's
 basically going to rewrite all commits.

 Regarding your Java-related questions: Classes are not yet public, because
 they were internal classes at the beginning, but they should be made
 public now. The reason for prefixing classes with `Parsed` was to avoid
 confusions with metrics-lib classes.

 Waiting for another review of the database parts before starting the bulk
 import. And to be clear, renaming things is okay even after finishing the
 import. But changing types or even table structures would be much harder.
 If you have any doubts about the database schema aggregating things
 correctly, please be sure to bring them up here!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24218#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs