[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24218 [Metrics/Statistics]: Implement new metrics-web module for IPv6 relay statistics

#24218: Implement new metrics-web module for IPv6 relay statistics
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  iwakeh              |        Sponsor:
--------------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:11 iwakeh]:
 > A quick glance tells me there is one
 [https://gitweb.torproject.org/karsten/metrics-web.git/tree/modules
 /servers-ipv6/src/main/resources/init-servers-
 ipv6.sql?h=tasks-24218-23761&id=ba969fe47c2c40949f3c51b6f9e80c9a633a52cc#n97
 'date' column left] in the view, which needs to be renamed.

 Huh, yes. Fixed now in [https://gitweb.torproject.org/karsten/metrics-
 web.git/commit/?h=tasks-24218-23761&id=3c6b01bcfa27537cafb28a3e31469b932ecb6b39
 commit 3c6b01b] (where I also updated the pgTAP tests which I forget
 earlier).

 > I used `psql (PostgreSQL) 9.5.10` (ubuntu), will check with 9.6 later (a
 quick update of my postgres failed :-/
 > Would be nice to have the 'on conflict'.

 It also works fine in my Debian squeeze VM. I'll for now assume it's a
 problem with your PostgreSQL version.

 > Regarding the structure I am wondering about more indexes, but these
 could be added later.

 True, we could add indexes later. Though I didn't spot any obviously
 missing indexes in my tests so far. The largest amount of data I imported
 was 2 years, but I didn't test continuous updates after that. I guess
 we'll learn.

 > Tests for the sql are missing to verify he results.  Just from reading
 it seems fine, but just reading.

 I think that what we have as tests is at least a start. To be honest, I'm
 not entirely happy with the JUnit/pgTAP mix here. But I hope that we'll
 improve that over time as we write more modules following this schema.

 Green light for archive import?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24218#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs