Re: [tor-bugs] #28743 [Core Tor/Tor]: Tinytest library leaks out into non-test codebase

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28743: Tinytest library leaks out into non-test codebase
--------------------------+------------------------
 Reporter:  karalabe      |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Trivial       |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------

Comment (by karalabe):

 Tinytest is part of `src/ext` per
 https://gitweb.torproject.org/tor.git/tree/src/ext?h=release-0.3.5 , which
 seems odd given that it's a test utility (why not put it into `src/test`).

 The `tinytest.c` file contains defines `TINYTEST_POSTFORK` in
 https://gitweb.torproject.org/tor.git/tree/src/ext/tinytest.c?h=release-0.3.5#n28,
 which causes it to add a link dependency for `void tinytest_prefork()` and
 `void tinytest_postfork()` per
 https://gitweb.torproject.org/tor.git/tree/src/ext/tinytest.c?h=release-0.3.5#n122
 .

 Those methods are defined in `src/test/testing_common.c` per
 https://gitweb.torproject.org/tor.git/tree/src/test/testing_common.c?h=release-0.3.5#n230
 .

 My annoyance is really with code organization, that a file in a library
 requires stuff defined in a test harness.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28743#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs