[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26843 [Applications/Tor Browser]: TBA: Investigate how Mozilla Fennec provides localization

#26843: TBA: Investigate how Mozilla Fennec provides localization
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-mobile, TBA-a2,                  |  Actual Points:
  GeorgKoppen201812, TorBrowserTeam201812        |
Parent ID:  #26782                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:27 gk]:
 > Replying to [comment:26 boklm]:
 > > In `bug_26843_v6`, I added a commit that will get the json file from
 our `tor-browser.git` clone:
 > > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26843_v6&id=1cffd6ce018e4114fa0e814602d5793646e6b10b
 > >
 > > To get the json file we use the `exec()` function, which will checkout
 the `git_hash` commit and run the command from there.
 >
 > You used `cat browser/locales/l10n-changesets.json` but we should take
 the .json file for now from the mobile directory as the l10n repos and
 revisions are used for Android only at the moment. Thus, `cat
 mobile/locales/l10n-changesets.json`. Otherwise this looks reasonable. I
 still need to test it, though.

 Alright, that seems to work. I compared the mobile/locales/ and the
 browser/locales/ l10n-changesets.json and it seems they differ a bit.
 Looking at https://product-details.mozilla.org/1.0/l10n/Firefox-60.3.0esr-
 build1.json it seems that one mirrors the file in browser/locales. Thus,
 as we ship for mobile I think it is good to use the one on mobile/locales
 instead.

 To save a roundtrip I've made that small change in the patch myself. The
 result is commit bad46e532fa614ffdd3ed0e21f4b8fae3ba7793d on `master`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26843#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs