[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28725 [Applications/Tor Browser]: Upgrade go-webrtc to dcbfc825aa33471253a5da1834d499257e05d557
#28725: Upgrade go-webrtc to dcbfc825aa33471253a5da1834d499257e05d557
-------------------------------------------------+-------------------------
Reporter: dcf | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: snowflake tbb-rbm, | Actual Points:
TorBrowserTeam201812 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by dcf):
* status: needs_revision => needs_review
Comment:
Here's another. I haven't tested it but the only difference is
{{{
- mkdir -p "$INCLUDE_DIR/$(dirname $h)"
+ mkdir -p "$INCLUDE_DIR/$(dirname "$h")"
}}}
Replying to [comment:6 gk]:
> I have both `third-party/llvm` and `third-party/llvm-build` for what
it's worth. `git status` run in `gclient/webrtc/src/third_party` gives
> {{{
> gk@stefan:~/tor-browser-build/gclient/webrtc/src/third_party$ git status
> HEAD detached at 6a94dad
> Untracked files:
> (use "git add <file>..." to include in what will be committed)
>
> gtest-parallel/
> llvm-build-tools/
> winsdk_samples/
> }}}
> Does that ring some bell?
Mine is different:
{{{
~/tor-browser-build/gclient/webrtc/src/third_party$ git status
HEAD detached at 6a94dad699
Untracked files:
(use "git add <file>..." to include in what will be committed)
gflags/
gtest-parallel/
}}}
`/llvm` is in `gclient/webrtc/src/third_party/.gitignore`, so I guess
because your checkout is older than mine you have some old leftover files.
Since upstream changed from storing all their headers under `webrtc/` to
storing them all under `./`, I suppose some extraneous cruft like that
gets included. I think it should be harmless.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28725#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs